This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
permit inline comments in requirement files #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Mark, Good call! This definitely looks like something we should support. Thanks for the pull request. @kylegibson Do you think we need to wait until someone can add a unit test verifying this before we merge it in? |
|
Awesome pull request! Thank you! |
kylegibson
added a commit
that referenced
this pull request
Apr 13, 2014
permit inline comments in requirement files
|
I think this breaks editable requirements which need |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.